feat(types,clerk-js): Introduce Custom OAuth providers by nikospapcom · Pull Request #3678 · clerk/javascript

nikospapcom · 2024-07-09T11:56:02Z

Description

This PR introduces custom OAuth provider support
Key changes include:

New types for custom OAuth providers and strategies
Modified social button to support providers without logos
New ProviderInitialIcon component for displaying provider initials

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-07-09T11:56:06Z

🦋 Changeset detected

Latest commit: c63ced4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages

Name	Type
@clerk/clerk-js	Minor
@clerk/types	Minor
@clerk/astro	Patch
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch
@clerk/backend	Patch
@clerk/elements	Patch
@clerk/express	Patch
@clerk/fastify	Patch
@clerk/localizations	Patch
@clerk/nextjs	Patch
@clerk/clerk-react	Patch
@clerk/remix	Patch
@clerk/clerk-sdk-node	Patch
@clerk/shared	Patch
@clerk/tanstack-start	Patch
@clerk/testing	Patch
@clerk/themes	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

nikospapcom · 2024-07-09T12:00:53Z

!snapshot

clerk-cookie · 2024-07-09T12:05:21Z

Hey @nikospapcom - the snapshot version command generated the following package versions:

Package	Version
@clerk/astro	0.0.2-snapshot.vc876098
@clerk/backend	1.3.1-snapshot.vc876098
@clerk/chrome-extension	1.1.3-snapshot.vc876098
@clerk/clerk-js	5.8.1-snapshot.vc876098
@clerk/elements	0.10.2-snapshot.vc876098
@clerk/clerk-expo	1.2.6-snapshot.vc876098
@clerk/express	0.0.16-snapshot.vc876098
@clerk/fastify	1.0.18-snapshot.vc876098
gatsby-plugin-clerk	5.0.0-beta.45
@clerk/localizations	2.4.8-snapshot.vc876098
@clerk/nextjs	5.2.3-snapshot.vc876098
@clerk/clerk-react	5.2.8-snapshot.vc876098
@clerk/remix	4.2.2-snapshot.vc876098
@clerk/clerk-sdk-node	5.0.15-snapshot.vc876098
@clerk/shared	2.3.3-snapshot.vc876098
@clerk/tanstack-start	0.1.6-snapshot.vc876098
@clerk/testing	1.1.10-snapshot.vc876098
@clerk/themes	2.1.12-snapshot.vc876098
@clerk/types	4.7.1-snapshot.vc876098
@clerk/ui	0.1.8-snapshot.vc876098

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro

npm i @clerk/astro@0.0.2-snapshot.vc876098 --save-exact

@clerk/backend

npm i @clerk/backend@1.3.1-snapshot.vc876098 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@1.1.3-snapshot.vc876098 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.8.1-snapshot.vc876098 --save-exact

@clerk/elements

npm i @clerk/elements@0.10.2-snapshot.vc876098 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@1.2.6-snapshot.vc876098 --save-exact

@clerk/express

npm i @clerk/express@0.0.16-snapshot.vc876098 --save-exact

@clerk/fastify

npm i @clerk/fastify@1.0.18-snapshot.vc876098 --save-exact

gatsby-plugin-clerk

npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact

@clerk/localizations

npm i @clerk/localizations@2.4.8-snapshot.vc876098 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@5.2.3-snapshot.vc876098 --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.2.8-snapshot.vc876098 --save-exact

@clerk/remix

npm i @clerk/remix@4.2.2-snapshot.vc876098 --save-exact

@clerk/clerk-sdk-node

npm i @clerk/clerk-sdk-node@5.0.15-snapshot.vc876098 --save-exact

@clerk/shared

npm i @clerk/shared@2.3.3-snapshot.vc876098 --save-exact

@clerk/tanstack-start

npm i @clerk/tanstack-start@0.1.6-snapshot.vc876098 --save-exact

@clerk/testing

npm i @clerk/testing@1.1.10-snapshot.vc876098 --save-exact

@clerk/themes

npm i @clerk/themes@2.1.12-snapshot.vc876098 --save-exact

@clerk/types

npm i @clerk/types@4.7.1-snapshot.vc876098 --save-exact

@clerk/ui

npm i @clerk/ui@0.1.8-snapshot.vc876098 --save-exact

nikospapcom · 2024-07-10T09:13:29Z

!snapshot

clerk-cookie · 2024-07-10T09:18:16Z

Hey @nikospapcom - the snapshot version command generated the following package versions:

Package	Version
@clerk/astro	0.0.2-snapshot.vce6e670
@clerk/backend	1.3.1-snapshot.vce6e670
@clerk/chrome-extension	1.1.3-snapshot.vce6e670
@clerk/clerk-js	5.8.1-snapshot.vce6e670
@clerk/elements	0.10.2-snapshot.vce6e670
@clerk/clerk-expo	1.2.6-snapshot.vce6e670
@clerk/express	0.0.16-snapshot.vce6e670
@clerk/fastify	1.0.18-snapshot.vce6e670
gatsby-plugin-clerk	5.0.0-beta.45
@clerk/localizations	2.4.8-snapshot.vce6e670
@clerk/nextjs	5.2.3-snapshot.vce6e670
@clerk/clerk-react	5.2.8-snapshot.vce6e670
@clerk/remix	4.2.2-snapshot.vce6e670
@clerk/clerk-sdk-node	5.0.15-snapshot.vce6e670
@clerk/shared	2.3.3-snapshot.vce6e670
@clerk/tanstack-start	0.1.6-snapshot.vce6e670
@clerk/testing	1.1.10-snapshot.vce6e670
@clerk/themes	2.1.12-snapshot.vce6e670
@clerk/types	4.7.1-snapshot.vce6e670
@clerk/ui	0.1.8-snapshot.vce6e670

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro

npm i @clerk/astro@0.0.2-snapshot.vce6e670 --save-exact

@clerk/backend

npm i @clerk/backend@1.3.1-snapshot.vce6e670 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@1.1.3-snapshot.vce6e670 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.8.1-snapshot.vce6e670 --save-exact

@clerk/elements

npm i @clerk/elements@0.10.2-snapshot.vce6e670 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@1.2.6-snapshot.vce6e670 --save-exact

@clerk/express

npm i @clerk/express@0.0.16-snapshot.vce6e670 --save-exact

@clerk/fastify

npm i @clerk/fastify@1.0.18-snapshot.vce6e670 --save-exact

gatsby-plugin-clerk

npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact

@clerk/localizations

npm i @clerk/localizations@2.4.8-snapshot.vce6e670 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@5.2.3-snapshot.vce6e670 --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.2.8-snapshot.vce6e670 --save-exact

@clerk/remix

npm i @clerk/remix@4.2.2-snapshot.vce6e670 --save-exact

@clerk/clerk-sdk-node

npm i @clerk/clerk-sdk-node@5.0.15-snapshot.vce6e670 --save-exact

@clerk/shared

npm i @clerk/shared@2.3.3-snapshot.vce6e670 --save-exact

@clerk/tanstack-start

npm i @clerk/tanstack-start@0.1.6-snapshot.vce6e670 --save-exact

@clerk/testing

npm i @clerk/testing@1.1.10-snapshot.vce6e670 --save-exact

@clerk/themes

npm i @clerk/themes@2.1.12-snapshot.vce6e670 --save-exact

@clerk/types

npm i @clerk/types@4.7.1-snapshot.vce6e670 --save-exact

@clerk/ui

npm i @clerk/ui@0.1.8-snapshot.vce6e670 --save-exact

octoper

💯

anagstef

Left some minor comments, but in general looks good! Great job!! 🚀

panteliselef

💯

nikospapcom · 2024-07-10T13:29:42Z

!snapshot

clerk-cookie · 2024-07-10T13:35:14Z

Hey @nikospapcom - the snapshot version command generated the following package versions:

Package	Version
@clerk/astro	0.0.2-snapshot.vf154a27
@clerk/backend	1.3.1-snapshot.vf154a27
@clerk/chrome-extension	1.1.3-snapshot.vf154a27
@clerk/clerk-js	5.9.0-snapshot.vf154a27
@clerk/elements	0.10.2-snapshot.vf154a27
@clerk/clerk-expo	1.2.6-snapshot.vf154a27
@clerk/express	0.0.16-snapshot.vf154a27
@clerk/fastify	1.0.18-snapshot.vf154a27
gatsby-plugin-clerk	5.0.0-beta.45
@clerk/localizations	2.4.8-snapshot.vf154a27
@clerk/nextjs	5.2.3-snapshot.vf154a27
@clerk/clerk-react	5.2.8-snapshot.vf154a27
@clerk/remix	4.2.2-snapshot.vf154a27
@clerk/clerk-sdk-node	5.0.15-snapshot.vf154a27
@clerk/shared	2.3.3-snapshot.vf154a27
@clerk/tanstack-start	0.1.6-snapshot.vf154a27
@clerk/testing	1.1.10-snapshot.vf154a27
@clerk/themes	2.1.12-snapshot.vf154a27
@clerk/types	4.8.0-snapshot.vf154a27
@clerk/ui	0.1.8-snapshot.vf154a27

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro

npm i @clerk/astro@0.0.2-snapshot.vf154a27 --save-exact

@clerk/backend

npm i @clerk/backend@1.3.1-snapshot.vf154a27 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@1.1.3-snapshot.vf154a27 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.9.0-snapshot.vf154a27 --save-exact

@clerk/elements

npm i @clerk/elements@0.10.2-snapshot.vf154a27 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@1.2.6-snapshot.vf154a27 --save-exact

@clerk/express

npm i @clerk/express@0.0.16-snapshot.vf154a27 --save-exact

@clerk/fastify

npm i @clerk/fastify@1.0.18-snapshot.vf154a27 --save-exact

gatsby-plugin-clerk

npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact

@clerk/localizations

npm i @clerk/localizations@2.4.8-snapshot.vf154a27 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@5.2.3-snapshot.vf154a27 --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.2.8-snapshot.vf154a27 --save-exact

@clerk/remix

npm i @clerk/remix@4.2.2-snapshot.vf154a27 --save-exact

@clerk/clerk-sdk-node

npm i @clerk/clerk-sdk-node@5.0.15-snapshot.vf154a27 --save-exact

@clerk/shared

npm i @clerk/shared@2.3.3-snapshot.vf154a27 --save-exact

@clerk/tanstack-start

npm i @clerk/tanstack-start@0.1.6-snapshot.vf154a27 --save-exact

@clerk/testing

npm i @clerk/testing@1.1.10-snapshot.vf154a27 --save-exact

@clerk/themes

npm i @clerk/themes@2.1.12-snapshot.vf154a27 --save-exact

@clerk/types

npm i @clerk/types@4.8.0-snapshot.vf154a27 --save-exact

@clerk/ui

npm i @clerk/ui@0.1.8-snapshot.vf154a27 --save-exact

…oduce tests for useEnabledThirdPartyProviders

…and address design system issues

nikospapcom self-assigned this Jul 9, 2024

clerk-cookie added types clerk-js labels Jul 9, 2024

nikospapcom force-pushed the nikospap/core-2598-introduce-custom-oauth-providers-in-clerkjavascript branch 2 times, most recently from bc3a76a to f5b9413 Compare July 10, 2024 07:34

nikospapcom marked this pull request as ready for review July 10, 2024 09:05

nikospapcom requested review from Nikpolik, anagstef, kostaspt, nikosdouvlis, octoper and panteliselef July 10, 2024 09:05

nikospapcom force-pushed the nikospap/core-2598-introduce-custom-oauth-providers-in-clerkjavascript branch from 97dae2b to ce6e670 Compare July 10, 2024 09:08

octoper reviewed Jul 10, 2024

View reviewed changes

Comment thread .changeset/unlucky-hornets-roll.md Outdated

Comment thread .changeset/unlucky-hornets-roll.md Outdated

nikospapcom force-pushed the nikospap/core-2598-introduce-custom-oauth-providers-in-clerkjavascript branch from ce6e670 to 2b99821 Compare July 10, 2024 09:33

octoper reviewed Jul 10, 2024

View reviewed changes

Comment thread packages/clerk-js/src/ui/hooks/__tests__/useEnabledThirdPartyProviders.test.tsx Outdated

nikospapcom force-pushed the nikospap/core-2598-introduce-custom-oauth-providers-in-clerkjavascript branch from 2b99821 to 65c5fbc Compare July 10, 2024 09:36

octoper approved these changes Jul 10, 2024

View reviewed changes

nikospapcom requested a review from dimkl July 10, 2024 09:40

anagstef reviewed Jul 10, 2024

View reviewed changes

Comment thread .changeset/unlucky-hornets-roll.md Outdated

anagstef reviewed Jul 10, 2024

View reviewed changes

Comment thread .changeset/unlucky-hornets-roll.md Outdated

anagstef reviewed Jul 10, 2024

View reviewed changes

Comment thread .changeset/unlucky-hornets-roll.md Outdated

anagstef reviewed Jul 10, 2024

View reviewed changes

Comment thread .changeset/unlucky-hornets-roll.md Outdated

panteliselef reviewed Jul 10, 2024

View reviewed changes

Comment thread packages/clerk-js/src/ui/components/UserProfile/ConnectedAccountsMenu.tsx Outdated

anagstef reviewed Jul 10, 2024

View reviewed changes

Comment thread packages/clerk-js/src/ui/common/InitialIcon.tsx Outdated

anagstef approved these changes Jul 10, 2024

View reviewed changes

panteliselef reviewed Jul 10, 2024

View reviewed changes

nikospapcom force-pushed the nikospap/core-2598-introduce-custom-oauth-providers-in-clerkjavascript branch 2 times, most recently from ac07f7a to 7b4599b Compare July 10, 2024 11:12

panteliselef approved these changes Jul 10, 2024

View reviewed changes

Comment thread .changeset/unlucky-hornets-roll.md Outdated

nikospapcom force-pushed the nikospap/core-2598-introduce-custom-oauth-providers-in-clerkjavascript branch from 98f9182 to f154a27 Compare July 10, 2024 12:46

nikospapcom force-pushed the nikospap/core-2598-introduce-custom-oauth-providers-in-clerkjavascript branch from f7a007f to e553bcc Compare July 12, 2024 06:56

nikospapcom added 3 commits July 15, 2024 09:00

feat(types,clerk-js): Introduce Custom OAuth providers

2637a67

chore(clerk-js): Sort authenticatableOauthStrategies by name and intr…

14cd59a

…oduce tests for useEnabledThirdPartyProviders

chore(clerk-js,types): Add element descriptor to ProviderInitialIcon …

c63ced4

…and address design system issues

nikospapcom force-pushed the nikospap/core-2598-introduce-custom-oauth-providers-in-clerkjavascript branch from e553bcc to c63ced4 Compare July 15, 2024 06:01

nikospapcom merged commit 0935cfc into main Jul 15, 2024

nikospapcom deleted the nikospap/core-2598-introduce-custom-oauth-providers-in-clerkjavascript branch July 15, 2024 10:38

clerk-cookie mentioned this pull request Jul 15, 2024

ci(repo): Version packages #3700

Merged

Uh oh!

Conversation

nikospapcom commented Jul 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Uh oh!

changeset-bot Bot commented Jul 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

nikospapcom commented Jul 9, 2024

Uh oh!

clerk-cookie commented Jul 9, 2024

Uh oh!

nikospapcom commented Jul 10, 2024

Uh oh!

clerk-cookie commented Jul 10, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

octoper left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anagstef left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

panteliselef left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nikospapcom commented Jul 10, 2024

Uh oh!

clerk-cookie commented Jul 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nikospapcom commented Jul 9, 2024 •

edited

Loading

changeset-bot Bot commented Jul 9, 2024 •

edited

Loading